Skip to content

Conversation

@evacchi
Copy link
Collaborator

@evacchi evacchi commented Oct 22, 2024

Reworded a few sections, this will need changes if #589 gets merged. Notably:

  • The HostFunction section now comes first, so I removed the reference to "using again memory" because this is the first time we are seeing it
  • I have also rounded up the section to introduce and clarify the concept of "host", "guest"
  • the description of the HostFunction should change to reflect Rename ExternalValues to ImportValues; order of params in ImportFunction,HostFunction. #589
  • we should also update this same section to use the Store from the start
  • we might describe later the alternate method (passing in "imports"/"external values" directly) for low-level access

EDIT: I did all the last 3 above as #589 was merged in the meantime

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi evacchi marked this pull request as ready for review October 23, 2024 13:01
@evacchi evacchi merged commit 8cd1741 into dylibso:main Oct 23, 2024
13 checks passed
@evacchi evacchi deleted the docs-reword branch October 23, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants